Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jackson Json dependency must not be in api #10384 #10935

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Jackson Json dependency must not be in api #10384 #10935

merged 7 commits into from
Feb 27, 2025

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Feb 24, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.25430% with 40 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (c029739) to head (1cd7bd6).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...a/com/enonic/xp/core/internal/json/JsonHelper.java 69.56% 5 Missing and 2 partials ⚠️
...in/java/com/enonic/xp/repository/IndexMapping.java 45.45% 6 Missing ⚠️
...n/java/com/enonic/xp/repository/IndexSettings.java 45.45% 6 Missing ⚠️
...i/src/main/java/com/enonic/xp/util/JsonHelper.java 0.00% 5 Missing ⚠️
...enonic/xp/repo/impl/index/IndexSettingsMerger.java 60.00% 3 Missing and 1 partial ⚠️
...epo/impl/repository/NodeRepositoryServiceImpl.java 89.47% 2 Missing ⚠️
...repo/impl/repository/RepositoryNodeTranslator.java 50.00% 2 Missing ⚠️
...om/enonic/xp/lib/repo/CreateRepositoryHandler.java 0.00% 2 Missing ⚠️
...om/enonic/xp/lib/repo/mapper/RepositoryMapper.java 50.00% 2 Missing ⚠️
.../java/com/enonic/xp/testing/helper/JsonAssert.java 83.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #10935      +/-   ##
============================================
+ Coverage     84.65%   84.67%   +0.02%     
+ Complexity    19949    19940       -9     
============================================
  Files          2620     2620              
  Lines         69329    69261      -68     
  Branches       5596     5567      -29     
============================================
- Hits          58690    58648      -42     
+ Misses         7932     7919      -13     
+ Partials       2707     2694      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rymsha rymsha force-pushed the jackson-json-dependency-must-not-be-in-api-2 branch from 6ddf512 to 28fbcbf Compare February 24, 2025 16:10
@rymsha rymsha marked this pull request as ready for review February 26, 2025 11:07
@rymsha rymsha force-pushed the jackson-json-dependency-must-not-be-in-api-2 branch from 658fbdb to 1cd7bd6 Compare February 27, 2025 16:12
@rymsha rymsha merged commit a406e8d into master Feb 27, 2025
5 of 6 checks passed
@rymsha rymsha deleted the jackson-json-dependency-must-not-be-in-api-2 branch February 27, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codacy-production codacy-production[bot] codacy-production[bot] left review comments

@vbradnitski vbradnitski vbradnitski approved these changes

@anatol-sialitski anatol-sialitski anatol-sialitski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymsha @vbradnitski @anatol-sialitski